Page 12 of 12
Re: AHCI
Posted: Mon Nov 15, 2021 8:16 pm
by rgimad
rgimad wrote:Your commit is very strange, for example in ahci_find_cmdslot, ahci_read, ahci_write why you use sd1_data (data of 1st ahci controller) ? It's incorrect, this functions are called not only for disks on 1st ahci controller. Also, uninformative naming: SD_DATA - it is not Sata Disk data, its data related to ahci controller.
Fixed this problems in
#9272. punk_joker, please test work of this new trunk revison on your hardware with multiple controllers and disks on them. I dont have such hardware.
Re: AHCI
Posted: Tue Nov 16, 2021 1:19 am
by punk_joker
I will test later. You can test in Qemu
Example, how to add multiple controllers:
Spoiler:
qemu-system-x86_64 \
-boot a \
-drive id=disk1,file=disk1.raw,if=none,format=raw \
-drive id=disk2,file=disk2.raw,if=none,format=raw \
-drive id=disk3,file=disk3.raw,if=none,format=raw \
-drive id=disk10,file=disk10.raw,if=none,format=raw \
-device ich9-ahci,id=ahci1 \
-device ich9-ahci,id=ahci2 \
-device ide-hd,drive=disk1,bus=ahci1.0 \
-device ide-hd,drive=disk3,bus=ahci2.0 \
-device nvme,serial=deadbeef,drive=disk2 \
-device ide-hd,drive=disk10,bus=ide.0 \
-fda kolibri.img \
-m 512M
Re: AHCI
Posted: Tue Nov 16, 2021 2:27 am
by punk_joker
Tested on my PC. Partitions are detected, and I can open them correctly.
Re: AHCI
Posted: Tue Nov 16, 2021 10:48 am
by rgimad
Good, thanks for information
Re: AHCI
Posted: Wed Nov 17, 2021 8:55 pm
by Leency
Tested on my PC. Issue is also soled, thanks.
Re: AHCI
Posted: Fri Nov 19, 2021 11:14 pm
by wataj77871
УРА! СЛАВА RGIMAD!!! Я ТАК ДОЛГО ЖДАЛ!!!