Board.KolibriOS.org

; project name: Tetris
; target platform: MenuetOS, x86 (IA-32), x86-64 achitectures
; compiler: flat assembler 1.61.9
; version: 1.6
; last update: 09th November 2005
; maintained by: Sergey Kuzmin aka Wildwest
; e-mail: kuzmin_serg@list.ru
;***************************************************************
HISTORY:
1.6: Tetris ********************************************09/11/2005
Author: Andrey Halyavin
Features: fix for work under MeosDebug & better random

1.5: Tetris ********************************************23/09/2005
Author: Sergey Kuzmin aka Wildwest
Features: fixed bug, when 011111111111111-like sequence interpreted
; as _11111111111111 in check_full_line

1.4: Tetris ********************************************18/09/2005
Author: Sergey Kuzmin aka Wildwest
Features: added 'Pause' button and made appropriate code and interface redesign
************BTW, you can MOVE and ROTATE block during Pause

1.3: Tetris ********************************************03/11/2003
Author: Ivan Poddubny
Features: added new blocks & random

1.2: Tetris ********************************************31/10/2001
Author: quickcode
Features: rdtsc replaced

1.1: Tetris ********************************************28/06/2001
Author: Ville Turjanmaa
Features: fasm port & framed blocks

1.0: Tetris ********************************************01/04/2001
Author: Paolo Minazzi
Features: initial version

And what do you want?

yogev_ezra: Hm, this one is Dmitry, which was mentioned in chat, or another student?

Wildwest wrote:And what do you want?

He wants to apply as a student, so he wants to submit a fix for Pause button bug: ftp://ftp.kolibrios.org/users/yogev_ezra/TetrisBug.avi (as one of prospective student requirements is to submit a bugfix or improvement via our SVN, to prove he/she can manage it). But since the topic on "Tetris" did not exist at all, I told him to start a new topic and copy the info from your website.

Wildwest wrote:Hm, this one is Dmitry, which was mentioned in chat, or another student?

No, totally different one. Dmitry is puhoshville

Hello,
My name is Arvind(dnivra on Freenode) and I'm interested in working with KolibriOS as a student during Google Summer of Code, 2014. I have been working on a bug yogev told me about in Tetris. I have included a description and and the patch for the bug in this post. It would be great if my patch could be reviwed and if it is good, then I could commit it to the SVN repository.

Description of bug
The pause button in Tetris does not work properly. In particular, the blocks can still be moved around and rotated which should not be possible.

Fix
Labels adr30, adr31 and adr32 point to the code which handles the UP, RIGHT and LEFT key press events. I added the following patch which executes the code associated with the key press events only if pause flag is not set.

dnivra
JFYI - it is possible to make only one check instead of five check: I believe you are understand how it can be implemented.