#9231 added support up to 8 controllers.
I just hard coded memory for 8 controllers, like in IDE driver. I will replace it on dynamic allocate later.
AHCI
-
to infinity and beyond
Wow, I remember your first commits in Eolite and now you add a support of 8 controllers in the SATA driver of Kernel. I am amazed!
Из хаоса в космос
После обновления #9231 не могу прочитать что-то из разделов кроме разде 2, в котором находится папка EFI, но и в этом разделе данные неверные(иногда пусто иногда какие-то странные надписи, похожие на данные из участков озу. После перезагрузки данные там меняются, прочесть содержимое этих файлов(директорий) невозможно ошибка 11, другие разделы пишут ошибку 9).
After update #9231, I can't read anything from the partitions except section 2, in which the EFI folder is located, but even in this section the data is incorrect (sometimes empty, sometimes some strange inscriptions similar to data from RAM sections. After a reboot, the data changes there, it is impossible to read the contents of these files (directories) error 11, other sections write error 9).
After update #9231, I can't read anything from the partitions except section 2, in which the EFI folder is located, but even in this section the data is incorrect (sometimes empty, sometimes some strange inscriptions similar to data from RAM sections. After a reboot, the data changes there, it is impossible to read the contents of these files (directories) error 11, other sections write error 9).
Это выглядит несколько костыльно, для CD/DVD дисков на AHCI контроллере теперь тоже новые имена наподобие scd придумывать?punk_joker wrote:#9219 use name sdX instead of hdX for AHCI SATA drives
Motivatios:
1. easier to understand drive is IDE or SATA.
2. fix issue: http://bugs.kolibrios.org/view.php?id=143
Я уже примерно понял как это можно решить, сделать чтобы disk_add возвращала 0, если диск с таким именем уже есть.
Таким образом драйвер AHCI сможет понять этот момент и подобрать свободное имя для диска. Если получится, возможно так и сделаю.
P.S. Насчет пункта 1: AHCI драйвер может писать в доску отладки что такой-то порт добавлен как диск такой-то.
Тоже будет понятно, какие диски SATA.
Last edited by rgimad on Sun Nov 14, 2021 11:18 pm, edited 3 times in total.
The best way to predict the future is to create it.
У нас уже есть разносе именованием для разных типов дисков.
hd - ide диски
bd - bios диски
tmp - RAM диски
Так-что sd вполне соответствует этой логике
hd - ide диски
bd - bios диски
tmp - RAM диски
Так-что sd вполне соответствует этой логике
to infinity and beyond
Send logs from board and pcidevDoczom wrote: After update #9231, I can't read anything from the partitions except section 2, in which the EFI folder is located, but even in this section the data is incorrect (sometimes empty, sometimes some strange inscriptions similar to data from RAM sections. After a reboot, the data changes there, it is impossible to read the contents of these files (directories) error 11, other sections write error 9).
to infinity and beyond
Oops, #9231 is TOTALLY broken. I run latest iso in qemu with two hard disks. (no matter one, two, etc. it doesnt work at all).
And see:
Before #9231 it worked normally.
And see:
Spoiler:
The best way to predict the future is to create it.
Are you sure? I just tested on my qemu latest image, and it works well. Your disks have GPT or MBR? And send board log from real PC and Qemu. And how to you run Qemu?rgimad wrote:Oops, #9231 is TOTALLY broken. I run latest iso in qemu with two hard disks. (no matter one, two, etc. it doesnt work at all).
And see:Before #9231 it worked normally.Spoiler:
Screenshot from 2021-11-14 16-02-11.png
to infinity and beyond
yes, builds before 9231 work well on my qemu, but >=9231 does not. I run:punk_joker wrote:Are you sure? I just tested on my qemu latest image, and it works well. Your disks have GPT or MBR? And send board log from real PC and Qemu. And how to you run Qemu?rgimad wrote:Oops, #9231 is TOTALLY broken. I run latest iso in qemu with two hard disks. (no matter one, two, etc. it doesnt work at all).
And see:Before #9231 it worked normally.Spoiler:
Screenshot from 2021-11-14 16-02-11.png
Spoiler:
qemu-system-i386 -m 256 -M q35 -cdrom kolibri.iso -boot d -vga vmware -net nic,model=rtl8139 -net user -soundhw ac97 -usb -usbdevice tablet -enable-kvm -drive file=fat:rw:. -drive file=fat:rw:two_hardThe best way to predict the future is to create it.
boardlog #9231 from qemu
Spoiler:
The best way to predict the future is to create it.
hd расшифровывается как hard disk, иначе было бы ided или что-то такое.punk_joker wrote:У нас уже есть разносе именованием для разных типов дисков.
hd - ide диски
bd - bios диски
tmp - RAM диски
Так-что sd вполне соответствует этой логике
Жесткий диск независимо от режима работы (sata или ide) это жесткий диск. То же и с оптическими дисками.
А вот флешка например это совсем другой тип устройств, тогда логично usbhd, да.
The best way to predict the future is to create it.
Checked. By default Qemu connect 2 disk to one AHCI controller. I tested in Qemu 1 disk per controller, the same configuration on my real PC. So, I think, I know where is a problem.
to infinity and beyond
Your commit is very strange, for example in ahci_find_cmdslot, ahci_read, ahci_write why you use sd1_data (data of 1st ahci controller) ? It's incorrect, this functions are called not only for disks on 1st ahci controller. Also, uninformative naming: SD_DATA - it is not Sata Disk data, its data related to ahci controller.
I will fix and refactor these.
On issue from messages above: yes, driver fails when adding second disk on one controller.
I will fix and refactor these.
On issue from messages above: yes, driver fails when adding second disk on one controller.
Last edited by rgimad on Mon Nov 15, 2021 3:23 pm, edited 4 times in total.
The best way to predict the future is to create it.
#9270 fixed failure when adding > 1 disks on one controller
The best way to predict the future is to create it.
Greatrgimad wrote:#9270 fixed failure when adding > 1 disks on one controller
to infinity and beyond
Who is online
Users browsing this forum: No registered users and 2 guests