Board.KolibriOS.org

Official KolibriOS board
It is currently Fri Aug 23, 2019 11:02 pm

All times are UTC+03:00




Post new topic  Reply to topic  [ 4 posts ] 
Author Message
PostPosted: Wed Feb 22, 2012 5:54 pm 
Offline
Mentor/Kernel Developer
User avatar

Joined: Fri Jun 30, 2006 9:01 am
Posts: 1248
In net branch, I used nested structures, for example:

Code:
struct  UDP_SOCKET              IP_SOCKET

        LocalPort               dw ?
        RemotePort              dw ?
        firstpacket             db ?

ends


Where UDP_SOCKET is a child of IP_SOCKET

For this i used struct.inc that is bundled with fasm.
The main (trunk) kernel however uses a simpler macro. The problem is that the macro in trunk uses a dot before all labels, while this macro does not.
Does anybody see a problem with me converting trunk kernel to use newer macro?

(I do not want to merge both kernels yet, but I need to update old code in net kernel, and it will be needed if i want to merge later.)

_________________
"Any intelligent fool can make things bigger, more complex, and more violent. It takes a touch of genius -- and a lot of courage -- to move in the opposite direction." Albert Einstein


Top
   
PostPosted: Wed Feb 22, 2012 6:38 pm 
Offline
Kernel Developer

Joined: Wed Mar 08, 2006 6:25 pm
Posts: 3952
I think it's a good idea.


Top
   
PostPosted: Wed Feb 22, 2012 6:47 pm 
Offline
Mentor/Kernel Developer
User avatar

Joined: Fri Jun 30, 2006 9:01 am
Posts: 1248
Ok done, hope I did not make many errors, but I think not.
Also, only the nescessary structs were changed to compile with struct.inc, not all structs were reviewed.

_________________
"Any intelligent fool can make things bigger, more complex, and more violent. It takes a touch of genius -- and a lot of courage -- to move in the opposite direction." Albert Einstein


Top
   
PostPosted: Thu Feb 23, 2012 10:31 pm 
Offline
Mentor/Kernel Developer
User avatar

Joined: Fri Jun 30, 2006 9:01 am
Posts: 1248
I updated most of the remaining structs to use this new syntax, and checked output files for binary differences, looks good :)

_________________
"Any intelligent fool can make things bigger, more complex, and more violent. It takes a touch of genius -- and a lot of courage -- to move in the opposite direction." Albert Einstein


Top
   
Display posts from previous:  Sort by  
Post new topic  Reply to topic  [ 4 posts ] 

All times are UTC+03:00


Who is online

Users browsing this forum: No registered users and 2 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB® Forum Software © phpBB Limited