Board.KolibriOS.org

Official KolibriOS board
It is currently Thu Apr 25, 2019 5:43 pm

All times are UTC+03:00




Post new topic  Reply to topic  [ 5 posts ] 
Author Message
 Post subject: Compilation of lang.inc
PostPosted: Thu Jul 29, 2010 11:05 pm 
Offline

Joined: Thu Jul 08, 2010 1:27 am
Posts: 7
I find it confusing when I see
include "lang.inc"
in the kernel.asm and cannot find the lang.inc file in the repository. Except
that I'm not sure if it's compliant with the theory of compilation to create
and delete a file during compilation but I'm not an expert...

Bost

Code:
---
 kernel.asm |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/kernel.asm b/kernel.asm
index 100621b..9e2b058 100644
--- a/kernel.asm
+++ b/kernel.asm
@@ -67,6 +67,8 @@ USE_COM_IRQ     equ 1      ; make irq 3 and irq 4 available for PCI devices
 
 include "proc32.inc"
 include "kglobals.inc"
+; the lang.inc exists only during the build process.
+; it is created and deleted by the build script (build.bat or make.sh)
 include "lang.inc"
 
 include "const.inc"
--
1.7.2


Top
   
PostPosted: Thu Jul 29, 2010 11:49 pm 
Why you do not using build.bat or make.sh?
lang.inc it is select language to blue boot screen.


Top
   
PostPosted: Fri Jul 30, 2010 12:15 pm 
Offline

Joined: Thu Jul 08, 2010 1:27 am
Posts: 7
Quote:
Why you do not using build.bat or make.sh? lang.inc it is select language to blue boot screen.

What I mean is:
Good: a build script (build.bat or make.sh) needs some source code (kernel.asm) (in order compile the project).
Bad: a build script needs some source code AND the source code needs a special build tool because the build tool creates a source code file (lang.inc) and without this new source file the project is not compilable.

Do you see my point now?

Bost


Top
   
PostPosted: Fri Jul 30, 2010 12:24 pm 
Offline
Mentor/Kernel Developer
User avatar

Joined: Fri Jun 30, 2006 9:01 am
Posts: 1247
A sollution is to put a lang.inc on the svn server.
This file should be set to be ignored when commiting new/changed files to the SVN.

_________________
"Any intelligent fool can make things bigger, more complex, and more violent. It takes a touch of genius -- and a lot of courage -- to move in the opposite direction." Albert Einstein


Top
   
PostPosted: Fri Jul 30, 2010 5:35 pm 
Offline

Joined: Thu Jul 08, 2010 1:27 am
Posts: 7
Quote:
A sollution is to put a lang.inc on the svn server. This file should be set to be ignored when commiting new/changed files to the SVN.
hmm... and then every time you need to change the lang.inc you need to perform
    unignore lang.inc
    commit lang.inc
    ignore lang.inc
that's a quite a lot of work (read 'potential mistakes') and I'm not sure if SVN supports anything like that. I.e. if a file ignored by SVN is downloaded when you run 'svn update'
I propose to put a comment to the 'include "lang.inc"' until we find any better solution.

Bost

PS: let's say wikipedia.org mirrors how people speaking different languages use internet and computers. So there are 42 languages with > 100k wikipedia articles so you need to change our lang.inc about 50 times
Code:
; the lang.inc exists only during the build process.
; it is created and deleted by the build script (build.bat or make.sh)
; this is not a good idea since the build script should not generade any
; source file, just compile the existing ones
include "lang.inc"


Top
   
Display posts from previous:  Sort by  
Post new topic  Reply to topic  [ 5 posts ] 

All times are UTC+03:00


Who is online

Users browsing this forum: No registered users and 2 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
cron
Powered by phpBB® Forum Software © phpBB Limited