Board.KolibriOS.org

Official KolibriOS board
It is currently Mon Dec 09, 2019 8:39 pm

All times are UTC+03:00




Post new topic  Reply to topic  [ 23 posts ]  Go to page 1 2 Next
Author Message
 Post subject: XFS
PostPosted: Wed Jul 17, 2013 11:33 pm 
Offline
Mentor
User avatar

Joined: Mon Oct 19, 2009 10:58 am
Posts: 441
Hello everyone!

I started working on XFS read/write support as a KSoC student.

Read support is in 'features are mostly implemented' state at the moment (one month is over). My current code, test kolibrios and hdd images and readme.txt (with more detailed description of how it is going) are located here. Feel free to aks me any related questions and report bugs.

Bug report includes outputs of the following commands:
  • xfs_db -c sb -c p -r DEVICE_NAME

    file/dir can't be read (run from the parent dir):
  • ls -a
  • ls -a | wc -l

    dir can't be read (run from the parent dir):
  • ls -a THAT_DIR_NAME
  • ls -a THAT_DIR_NAME | wc -l

Passing -r option to xfs_db means 'read only'. You can run it safely on any (even mounted) device.

If you can provide partition image, say, below 10GB (if you can, you know how to do it) -- that is the best option.

Please, be precise while reporting bugs and patient anyway.


Top
   
 Post subject: Re: XFS
PostPosted: Mon Jul 29, 2013 3:04 pm 
Offline

Joined: Wed May 18, 2005 7:27 pm
Posts: 1001
Who is your mentor? Why he don't write his opinion here? What happened with Shikhin?


Top
   
 Post subject: Re: XFS
PostPosted: Mon Jul 29, 2013 3:08 pm 
Offline
Public Relations
User avatar

Joined: Mon Jun 07, 2010 12:01 pm
Posts: 1879
Wildwest wrote:
Who is mentor? Why he don't write his opinion here?
Formal mentor is XVilka but he isn't really involved. CleverMouse, Mario and Serge actually answered the questions. I suggest that dunkaist commits his code in our SVN, and if the code compiles and doesn't break any other existing functionality, for me it's enough to pay him for the 1st month.
Wildwest wrote:
What happened with Shikhin?
Shikhin's grandfather passed away, so I gave him a temporary "leave of absence". He should be back soon, I suppose.


Top
   
 Post subject: Re: XFS
PostPosted: Mon Jul 29, 2013 3:10 pm 
Offline

Joined: Mon Sep 24, 2007 11:11 am
Posts: 2814
dunkaist wrote:
Hello everyone!


Good job! I tested your attached files, works great. Sorry, I haven't any XFS partitions :(


Top
   
 Post subject: Re: XFS
PostPosted: Mon Jul 29, 2013 9:20 pm 
Offline
Mentor
User avatar

Joined: Mon Oct 19, 2009 10:58 am
Posts: 441
yogev_ezra,
I think it's a good idea to commit the code to svn, at least read-only part. What is called 'writing' at the moment will damage fs for sure). But I'd like to fix some reading bugs first which are still here because I'm currently more concentrated on understanding writing logic and basic inode allocating process. It will definitely happen in one-two weeks and it seems to me logically to be paid when the code is committed.

SoUrcerer wrote:
Good job! I tested your attached files, works great. Sorry, I haven't any XFS partitions
Thanks! To be honest, XFS image is quite outdated. I mean the current code handles more ondisk file/dir formats than that 02.xfs has. However, as I wrote above, there is still something to do before read support is complete. I will probably provide more sophisticated 0?.xfs though it is hard to fit a btree dir with over 100,000 entries into < 10M file.


Top
   
 Post subject: Re: XFS
PostPosted: Tue Aug 06, 2013 8:26 pm 
Offline

Joined: Wed May 18, 2005 7:27 pm
Posts: 1001
Shikhin doesn't visit forum for 5 days already...
memberlist.php?mode=viewprofile&u=5817
I think it is better to cancel payment to him and hire 1 or 2 students for another (easier) task(s) and shorter term.


Top
   
 Post subject: Re: XFS
PostPosted: Tue Aug 06, 2013 8:47 pm 
Offline
Public Relations
User avatar

Joined: Mon Jun 07, 2010 12:01 pm
Posts: 1879
Wildwest wrote:
Shikhin doesn't visit forum for 5 days already...
memberlist.php?mode=viewprofile&u=5817
I think it is better to cancel payment to him and hire 1 or 2 students for another (easier) task(s) and shorter term.
I have sent him a private message now, and offered to step off and allow us to take another student for another task. If he needs a few more days to mourn his grandfather's death, I completely understand that and have no problem to give him those days, but he should communicate it openly to all forum members, and not just disappear.


Top
   
 Post subject:
PostPosted: Sat Aug 31, 2013 12:53 pm 
Offline
Public Relations
User avatar

Joined: Mon Jun 07, 2010 12:01 pm
Posts: 1879
Any idea on when do you plan to commit read support to SVN? Your first salary is long overdue because it's pending that commit.


Top
   
 Post subject: Re: XFS
PostPosted: Sat Aug 31, 2013 4:50 pm 
Offline
Mentor
User avatar

Joined: Mon Oct 19, 2009 10:58 am
Posts: 441
yogev_ezra wrote:
Any idea on when do you plan to commit read support to SVN?
I will commit/update_on_ftp all the stable/unstable code I have until the last deadline, since final report requires full code.

yogev_ezra wrote:
Your first salary is long overdue because it's pending that commit.
It seems ok to me because you know that feature is implemented (ftp) and I know that I'll get corresponding salary (same reason).


Currently I'm trying to get some working configurations of write support. I wouldn't like my final report has words "many functions are written, but I steel need to write several ones before you can try/test anything".

Thank you for your patience!


Top
   
 Post subject: Re: XFS
PostPosted: Wed Sep 18, 2013 1:36 am 
Offline
Mentor
User avatar

Joined: Mon Oct 19, 2009 10:58 am
Posts: 441
Hello, everyone!

Here is my report for read only part of XFS support.

It should work if:
  • you didn't pass custom options to mkfs.xfs (you know if you did);
  • you don't use new/exotic features like CRC protection of meta-data.

My further aim for reading is to increase speed and stability (e.g. on fragmented files) and provide support for more custom flags/features.
Current code is committed to repository. Test images are uploaded to ftp.

Below is a screenshot of my code in action. Text file, wav track (seeking does work!), dancing girl picture (she moves too fast, so gif animation looks like slideshow in qemu) and huge directory of 33333 entries (try browse it).

Spoiler: Show
Image

Feel free to test and report bugs,
thank you for your patience!


Top
   
 Post subject: Re: XFS
PostPosted: Wed Sep 18, 2013 7:25 am 
Offline
Kernel Developer

Joined: Sun Feb 10, 2013 12:37 pm
Posts: 2329
dunkaist
Good job.

_________________
Всем чмоки в этом проекте! Засуньте эти 11 лет себе в жопу!


Top
   
 Post subject: Re: XFS
PostPosted: Thu Sep 19, 2013 2:54 am 
Offline
Mentor
User avatar

Joined: Mon Oct 19, 2009 10:58 am
Posts: 441
And here is my report for writing part of XFS support.

First of all, do not test kolibri_rw.img on real hardware! The code is on ftp right now, so you can still use nightbuilds safely.

Unfortunately, writing is much harder to implement than reading. But though I didn't promise stable write support I don't consider its current state satisfactory. Uploaded test image (09.xfs.xz) contains several nested directories with files to delete them.

The reasons (besides task complexity) are my laziness in August and studying at the university in September.
I'd ask to move my final deadline to 17 October as to provide more adequate code and get positive reviews.

Below is an image with KFM: both panels show the same directory before and after deletion of files/dirs (kolibri_rw.img, 09.xfs).
Spoiler: Show
Image


Top
   
 Post subject: Re: XFS
PostPosted: Thu Sep 19, 2013 6:04 pm 
Offline

Joined: Tue Apr 12, 2011 11:19 pm
Posts: 1151
The image where only read - everything works fine. And here in the form of test data record does not even open section. As asked by a General impression. If you will need the logs to you. Tested it in VirtualBox.

_________________
я лишь учусь


Top
   
 Post subject: Re: XFS
PostPosted: Thu Sep 19, 2013 6:37 pm 
Offline
Mentor
User avatar

Joined: Mon Oct 19, 2009 10:58 am
Posts: 441
punk_joker wrote:
The image where only read - everything works fine.
Glad to read, thank you for testing.

punk_joker wrote:
And here in the form of test data record does not even open section. As asked by a General impression. If you will need the logs to you. Tested it in VirtualBox.
I use qemu 1.2.2 since there is very similar problem with current qemu 1.5.2.

Please, try attach other hdd images with different file systems on them and specify VirtualBox version. I didn't really go into details with this problem, it doesn't seem to me to be XFS related.


Top
   
 Post subject: Re: XFS
PostPosted: Fri Sep 20, 2013 10:37 pm 
Offline

Joined: Tue Apr 12, 2011 11:19 pm
Posts: 1151
Tested on a real system. Reading works in both cases. The record is not working at all.

_________________
я лишь учусь


Top
   
Display posts from previous:  Sort by  
Post new topic  Reply to topic  [ 23 posts ]  Go to page 1 2 Next

All times are UTC+03:00


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
cron
Powered by phpBB® Forum Software © phpBB Limited